Re: [PATCH RFC v3 2/4] spmi: pmic-arb: Make the APID init a version operation

From: Konrad Dybcio
Date: Wed Feb 14 2024 - 16:17:12 EST


On 14.02.2024 22:13, Abel Vesa wrote:
> Rather than using conditionals in probe function, add the APID init
> as a version specific operation. Due to v7, which supports multiple
> buses, pass on the bus index to be used for sorting out the apid base
> and count.
>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> ---

[...]


> +
> /*
> * v5 offset per ee and per apid for observer channels and per apid for
> * read/write channels.
> @@ -1178,6 +1246,49 @@ static int pmic_arb_offset_v5(struct spmi_pmic_arb *pmic_arb, u8 sid, u16 addr,
> return offset;
> }
>
> +/*
> + * Only v7 supports 2 bus buses. Each bus will get a different apid count,

"bus buses"?

Konrad