Re: [patch 11/12] x86/resctrl: use smp_call_function_single_fail

From: Marcelo Tosatti
Date: Wed Feb 14 2024 - 14:06:10 EST


On Mon, Feb 12, 2024 at 04:19:19PM +0100, Thomas Gleixner wrote:
> On Tue, Feb 06 2024 at 15:49, Marcelo Tosatti wrote:
> > Convert update_task_closid_rmid from smp_call_function_single
> > to smp_call_func_single_fail, which will fail in case
> > the target CPU is tagged as block interference CPU.
>
> You fail again to provide a rationale for this change.
>
> What's worse is that you fail to explain why you think that creating
> inconistent state is a valid approach.

Well, the patch is broken and needs fixing.