Re: [PATCH v1 1/1] kernel.h: Move upper_*_bits() and lower_*_bits() to wordpath.h

[Kees Cook]

On Wed, Feb 14, 2024 at 08:12:00PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 14, 2024 at 10:09:10AM -0800, Randy Dunlap wrote:
> > On 2/14/24 09:26, Andy Shevchenko wrote:
> > > The wordpart.h header is collecting APIs related to the handling
> > > parts of the word (usually in byte granularity). The upper_*_bits()
> > > and lower_*_bits() are good candidates to be moved to there.
> > > 
> > > This helps to clean up header dependency hell with regard to kernel.h
> > > as the latter gathers completely unrelated stuff together and slows
> > > down compilation (especially when it's included into other header).
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > > 
> > > Kees, since wordpart.h is now only in your tree, this is supposed
> > > to go there as well.
> > 
> > after someone corrects the Subject (wordpath -> wordpart).
> 
> Oh, indeed. Thanks for spotting this!
> Kees, should I send a v2 or you can amend when applying?

I've amended it; thanks for the catch Randy!

-Kees

> 
> > Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> 
> Thanks!
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

-- 
Kees Cook