Re: [PATCH] dt-bindings: mfd: Convert atmel-flexcom to json-schema

[Conor Dooley]

On Wed, Feb 14, 2024 at 11:13:43AM +0530, Balakrishnan Sambath wrote:
> From: Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx>
> 
> Convert the Atmel flexcom device tree bindings to json schema.
> 
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@xxxxxxxxxxxxx>
> ---
> The yaml DT bindings for the atmel-flexcom driver were submitted
> upstream in a separate patch series in 2022 [1] which was Acked-by
> Krzysztof Kozlowski. However, it has been observed recently that the
> patch has not been merged into the mainline codebase.When attempting to
> apply the patch to the latest upstream kernel,a conflict arose due to a
> recent addition to the original device tree binding in text format. The
> conflict has now been resolved and we are sending a updated version of
> the patch. 

I don't think you actually resolved this conflict:

> +properties:
> +  compatible:
> +    enum:
> +      - atmel,sama5d2-flexcom

> -- compatible:		Should be "atmel,sama5d2-flexcom"

> -			or "microchip,sam9x7-flexcom", "atmel,sama5d2-flexcom"

This line here is the "recent addition", but this is not in the new yaml
binding.

Please fix!

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature