Re: [PATCH net-next v3 10/17] dt-bindings: net: pse-pd: Add another way of describing several PSE PIs

[Köry Maincent]

On Wed, 14 Feb 2024 14:13:10 +0100
Köry Maincent <kory.maincent@xxxxxxxxxxx> wrote:

> Hello Rob,
> 
> Thanks for your review!
> 
> On Fri, 9 Feb 2024 14:43:49 +0000
> Rob Herring <robh@xxxxxxxxxx> wrote:
> 
> > On Thu, Feb 08, 2024 at 02:08:47PM +0100, Kory Maincent wrote:  
> > > Before hand we set "#pse-cell" to 1 to define a PSE controller with    
> > 
> > #pse-cells
> >   
> > > several PIs (Power Interface). The drawback of this was that we could not
> > > have any information on the PI except its number.    
> > 
> > Then increase it to what you need. The whole point of #foo-cells is that 
> > it is variable depending on what the provider needs. 
> >   
> > > Add support for pse_pis and pse_pi node to be able to have more
> > > information on the PI like the number of pairset used and the pairset
> > > pinout.    
> > 
> > Please explain the problem you are trying to solve, not your solution. I 
> > don't understand what the problem is to provide any useful suggestions 
> > on the design.  
> 
> Please see Oleksij's reply.
> Thank you Oleksij, for the documentation!!
> 
> > > 
> > > Sponsored-by: Dent Project <dentproject@xxxxxxxxxxxxxxxxxxx>    
> > 
> > Is this a recognized tag? First I've seen it.  
> 
> This is not a standard tag but it has been used several times in the past.

Not so much used indeed:
$ git log --grep="Sponsored" | grep Sponsored     
    Sponsored by:  The FreeBSD Foundation
    Sponsored by:  The FreeBSD Foundation
    Sponsored by:  The FreeBSD Foundation
    Sponsored by:  The FreeBSD Foundation
    Sponsored-by: Google Chromium project
    Sponsored: Google ChromeOS
    Sponsored: Google ChromeOS

Is it ok to keep it?

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com