Re: [PATCH V2 2/2] pwm: mediatek: add support for MT7988

From: Daniel Golle
Date: Wed Feb 14 2024 - 09:12:57 EST


On Wed, Feb 14, 2024 at 03:04:54PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> MT7988 uses new registers layout just like MT7981 but it supports 8 PWM
> interfaces.
>
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>

Reviewed-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

> ---
> V2: New patch in the series
>
> drivers/pwm/pwm-mediatek.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> index 562102a47ac0..292c8bd5b343 100644
> --- a/drivers/pwm/pwm-mediatek.c
> +++ b/drivers/pwm/pwm-mediatek.c
> @@ -339,6 +339,13 @@ static const struct pwm_mediatek_of_data mt7986_pwm_data = {
> .reg_offset = mtk_pwm_reg_offset_v1,
> };
>
> +static const struct pwm_mediatek_of_data mt7988_pwm_data = {
> + .num_pwms = 8,
> + .pwm45_fixup = false,
> + .has_ck_26m_sel = false,
> + .reg_offset = mtk_pwm_reg_offset_v2,
> +};
> +
> static const struct pwm_mediatek_of_data mt8183_pwm_data = {
> .num_pwms = 4,
> .pwm45_fixup = false,
> @@ -369,6 +376,7 @@ static const struct of_device_id pwm_mediatek_of_match[] = {
> { .compatible = "mediatek,mt7629-pwm", .data = &mt7629_pwm_data },
> { .compatible = "mediatek,mt7981-pwm", .data = &mt7981_pwm_data },
> { .compatible = "mediatek,mt7986-pwm", .data = &mt7986_pwm_data },
> + { .compatible = "mediatek,mt7988-pwm", .data = &mt7988_pwm_data },
> { .compatible = "mediatek,mt8183-pwm", .data = &mt8183_pwm_data },
> { .compatible = "mediatek,mt8365-pwm", .data = &mt8365_pwm_data },
> { .compatible = "mediatek,mt8516-pwm", .data = &mt8516_pwm_data },
> --
> 2.35.3
>
>