Re: [PATCH] sh: hd64461: Make setup_hd64461 static

From: John Paul Adrian Glaubitz
Date: Wed Feb 14 2024 - 07:57:43 EST


On Sun, 2024-02-11 at 20:34 +0100, Artur Rojek wrote:
> Enforce internal linkage for setup_hd64461.
>
> This fixes the following error:
> arch/sh/cchips/hd6446x/hd64461.c:75:12: error: no previous prototype for 'setup_hd64461' [-Werror=missing-prototypes]
>
> Signed-off-by: Artur Rojek <contact@xxxxxxxxxxxxxx>
> ---
> arch/sh/cchips/hd6446x/hd64461.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/cchips/hd6446x/hd64461.c b/arch/sh/cchips/hd6446x/hd64461.c
> index f3fba967445a..81764882d87d 100644
> --- a/arch/sh/cchips/hd6446x/hd64461.c
> +++ b/arch/sh/cchips/hd6446x/hd64461.c
> @@ -72,7 +72,7 @@ static void hd64461_irq_demux(struct irq_desc *desc)
> }
> }
>
> -int __init setup_hd64461(void)
> +static int __init setup_hd64461(void)
> {
> int irq_base, i;
>

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>

I will merge this patch for 6.9 tonight.

Thanks,
Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913