Re: [PATCH v3 3/7] arm64: dts: ti: iot2050: Factor out arduino connector bits

From: Jan Kiszka
Date: Wed Feb 14 2024 - 06:22:13 EST


On 14.02.24 11:13, Vignesh Raghavendra wrote:
>
>
> On 09/02/24 12:53, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>>
>> A new variant is to be added which will not have a arduino connector
>> like the existing ones. Factor out all bits that are specific to this
>> connector.
>>
>> The split is not perfect because wkup_gpio0 is defined based on what is
>> common to all variants having the connector, thus containing also
>> connector-unrelated information. But this is still cleaner than
>> replicating this node into all 4 variants.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>> ---
>> .../ti/k3-am65-iot2050-arduino-connector.dtsi | 768 ++++++++++++++++++
>> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 753 -----------------
>> .../ti/k3-am6528-iot2050-basic-common.dtsi | 1 +
>> .../dts/ti/k3-am6548-iot2050-advanced-m2.dts | 1 +
>> .../dts/ti/k3-am6548-iot2050-advanced-pg2.dts | 1 +
>> .../dts/ti/k3-am6548-iot2050-advanced.dts | 1 +
>> 6 files changed, 772 insertions(+), 753 deletions(-)
>> create mode 100644
>> arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>>
>> diff --git
>> a/arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>> b/arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>> new file mode 100644
>> index 000000000000..cd86f412b837
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>> @@ -0,0 +1,768 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
> This and elsewhere in the series should be
>
> // SPDX-License-Identifier: GPL-2.0-only
>
> as fixed up by Nishanth in [0]. I can fix that locally, let me know.
>

Yes, please.

> [0] https://lore.kernel.org/r/20240122145539.194512-16-nm@xxxxxx
>

Thanks,
Jan

--
Siemens AG, Technology
Linux Expert Center