Re: [PATCH] wifi: ath12k: sanitize ath12k_mac_allocate() return code

[Kalle Valo]

"Arnd Bergmann" <arnd@xxxxxxxx> writes:

> On Wed, Feb 14, 2024, at 09:44, Kalle Valo wrote:
>> Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>>
>>> The return code has no initializer:
>>> 
>>> drivers/net/wireless/ath/ath12k/mac.c:8006:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>>> 
>>> Make it return -ENOMEM for allocation failures and remove the unused
>>> variable instead.
>>> 
>>> Fixes: 6db6e70a17f6 ("wifi: ath12k: Introduce the container for mac80211 hw")
>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>
>>
>> Nathan already fixed this:
>>
>> https://git.kernel.org/kvalo/ath/c/04edb5dc68f4
>>
>> Patch set to Rejected.
>
> Ok, sounds good. Nathan's patch looks fine to me

Great, thanks for checking.

> but I see it's not in linux-next yet as of today.

Yeah, it's a problem that ath.git is not included linux-next builds. The
commits will be in linux-next only after ath-next is pulled to
wireless-next :/

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches