Re: [PATCH] riscv: use KERN_INFO in do_trap

[Conor Dooley]

On 14/02/2024 10:10, Andreas Schwab wrote:
> On Feb 14 2024, Conor Dooley wrote:
>
> > On Tue, Feb 13, 2024 at 10:59:58AM +0100, Andreas Schwab wrote:
> > > Print the instruction dump with info instead of emergency level like the
> > > rest of the output when printing the information for an unhandled signal.
> >
> > I'm not entirely sure that this is true, __show_regs() prints with
> > KERN_DEFAULT, but this certainly is more consistent than it was before.
>
> The first line is printed with pr_info.

Yah, that's what I meant with "more consistent" :)

> Perhaps __show_regs should gain
> a level argument.

I wouldn't be averse. There's 3 users, of which one is show_regs().
I think we could easily add an argument that sets the printk level
to match the other outputs from the non show_regs() callers. I
suppose show_regs() could retain the KERN_DEFAULT behaviour unless
you've got a better idea.