Re: [tip:timers/core 3/3] kernel/time/hrtimer.c:2224:49: error: implicit declaration of function 'housekeeping' is invalid in C99

[Frederic Weisbecker]

On Wed, Feb 14, 2024 at 05:33:56PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core
> head:   86342554e102b0d18d50abec43d40f4fc92f1993
> commit: 86342554e102b0d18d50abec43d40f4fc92f1993 [3/3] hrtimer: Select housekeeping CPU during migration
> config: arm-defconfig (https://download.01.org/0day-ci/archive/20240214/202402141742.oYY6J3lC-lkp@xxxxxxxxx/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240214/202402141742.oYY6J3lC-lkp@xxxxxxxxx/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202402141742.oYY6J3lC-lkp@xxxxxxxxx/
> 
> All errors (new ones prefixed by >>):
> 
>    kernel/time/hrtimer.c:1651:7: warning: variable 'expires_in_hardirq' set but not used [-Wunused-but-set-variable]
>            bool expires_in_hardirq;
>                 ^
> >> kernel/time/hrtimer.c:2224:49: error: implicit declaration of function 'housekeeping' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>            int i, ncpu = cpumask_any_and(cpu_active_mask, housekeeping(HK_TYPE_TIMER));
>                                                           ^
> >> kernel/time/hrtimer.c:2224:62: error: use of undeclared identifier 'HK_TYPE_TIMER'
>            int i, ncpu = cpumask_any_and(cpu_active_mask, housekeeping(HK_TYPE_TIMER));
>                                                                        ^
>    1 warning and 2 errors generated.
> 
> 
> vim +/housekeeping +2224 kernel/time/hrtimer.c
> 
>   2221	
>   2222	int hrtimers_cpu_dying(unsigned int dying_cpu)
>   2223	{
> > 2224		int i, ncpu = cpumask_any_and(cpu_active_mask, housekeeping(HK_TYPE_TIMER));

Should be housekeeping_cpumask(HK_TYPE_TIMER)

Thanks.