Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

[neil . armstrong]

On 14/02/2024 10:33, Luca Weiss wrote:
> On Mon Jan 22, 2024 at 12:27 PM CET, Luca Weiss wrote:
> > On Fri Jan 12, 2024 at 11:26 AM CET,  wrote:
> > > On 12/01/2024 11:23, Linus Walleij wrote:
> > > > On Fri, Jan 12, 2024 at 10:52 AM Luca Weiss <luca.weiss@xxxxxxxxxxxxx> wrote:
> > > >
> > > > > Since there's zero indication Truly is involved in this panel in my
> > > > > documentation - much less the number 5P65 - I'm not going to add that.
> > >
> > > Ack
> > >
> > > > OK then, I fold, thanks for looking into it.
> > > > Keep the Himax hx83112a file name and symbols.
> > > >
> > > > > So in short this panel is the model 9A-3R063-1102B from DJN, which uses
> > > > > a Himax HX83112A driver IC.
> > > >
> > > > So compatible = "djn,9a-3r063-1102b" since the setup sequences for
> > > > hx83112a are clearly for this one display?
> > >
> > > Yep let's settle on that!
>
> Hi Neil and Linus,
>
> Any feedback about the below question?
>
> Regards
> Luca
>
> > It's clear to me to use "djn,9a-3r063-1102b" in the driver now but what
> > about dts?
> >
> > Currently here in v2 we have this:
> > compatible = "fairphone,fp4-hx83112a-djn", "himax,hx83112a";
> >
> > Should this just become this?
> > compatible = "djn,9a-3r063-1102b";
> >
> > Or e.g. this?
> > compatible = "djn,9a-3r063-1102b", "himax,hx83112a";
> >
> > Or something else completely? Do we have some documentation / best
> > practises around this maybe?

Sorry I totally missed the question.

Not sure if "himax,hx83112a" is needed here, the "djn,9a-3r063-1102b" is enough to know the IC is hx83112a.

I don't think you'll ever find a "djn,9a-3r063-1102b" with another controller IC ?

And "himax,hx83112a" alone as fallback is not enough to describe the panel hardware, so I think it should be dropped.

Thanks,
Neil

> > Regards
> > Luca
> >
> > > Thanks,
> > > Neil
> > >
> > > > Yours,
> > > > Linus Walleij