Re: [PATCH] brcmsmac: avoid function pointer casts

[Arend van Spriel]

On 2/14/2024 9:45 AM, Kalle Valo wrote:
> Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > An old cleanup went a little too far and causes a warning with clang-16
> > and higher as it breaks control flow integrity (KCFI) rules:
> >
> > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy_shim.c:64:34: error: cast from 'void (*)(struct brcms_phy *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
> >     64 |                         brcms_init_timer(physhim->wl, (void (*)(void *))fn,
> >        |                                                       ^~~~~~~~~~~~~~~~~~~~
> >
> > Change this one instance back to passing a void pointer so it can be
> > used with the timer callback interface.
> >
> > Fixes: d89a4c80601d ("staging: brcm80211: removed void * from softmac phy")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> I guess this should go to wireless tree?

This has been like this forever looking at the "staging" part in the 
Fixes tag. Is it really so urgent now? On the other hand I have no real 
problem with moving this to the wireless tree. Just wondering out loud.

Regards,
Arend

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature