Re: [PATCH v1 1/1] serial: 8250_pci1xxxx: Don't use "proxy" headers

From: Jiri Slaby
Date: Wed Feb 14 2024 - 04:15:21 EST


On 13. 02. 24, 20:38, Andy Shevchenko wrote:
Update header inclusions to follow IWYU (Include What You Use)
principle.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Looks good, but hard to tell if it is correct :P.

I like this qt-creator feature: "this header is not directly used, remove?". Maybe we could extend it to the kernel somehow (as it uses clang to decide, I suppose). As was shown recently, removing the inclusion hell can decrease the build time significantly…

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

--
js
suse labs