Re: [PATCH 1/2] dt-bindings: pwm: mediatek,mt2712: add compatible for MT7988
From: Krzysztof Kozlowski
Date: Wed Feb 14 2024 - 04:06:05 EST
On 13/02/2024 18:48, Uwe Kleine-König wrote:
> Hello Rafał,
>
> On Tue, Feb 13, 2024 at 05:46:32PM +0100, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@xxxxxxxxxx>
>>
>> MT7988 has on-SoC controller that can control up to 8 PWMs.
>>
>> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> please make sure that the email address used for sending the patch
> matches the Signed-off-by line.
>
> (It depends on the pickyness of the relevant maintainer if that is a
> stopper or not.)
Does not have to... It must match From field which is correct here.
Syntax like:
From: Foo <foo@com>
Signed-off-by: Foo <foo@com>
Signed-off-by: Foo <my-other-email-foo@com>
makes sense only if copyrights change (e.g. change of employers) and/or
one email stop working. How would be the point of having to SoBs for the
same person in other cases?
Best regards,
Krzysztof