Re: [PATCH] wifi: ath12k: sanitize ath12k_mac_allocate() return code

From: Kalle Valo
Date: Wed Feb 14 2024 - 03:44:29 EST


Arnd Bergmann <arnd@xxxxxxxxxx> wrote:

> The return code has no initializer:
>
> drivers/net/wireless/ath/ath12k/mac.c:8006:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>
> Make it return -ENOMEM for allocation failures and remove the unused
> variable instead.
>
> Fixes: 6db6e70a17f6 ("wifi: ath12k: Introduce the container for mac80211 hw")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>

Nathan already fixed this:

https://git.kernel.org/kvalo/ath/c/04edb5dc68f4

Patch set to Rejected.

--
https://patchwork.kernel.org/project/linux-wireless/patch/20240213100912.459018-1-arnd@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches