Re: [syzbot] [dri?] KASAN: slab-use-after-free Read in drm_atomic_helper_wait_for_vblanks (2)

From: syzbot
Date: Wed Feb 14 2024 - 02:26:11 EST


Hello,

syzbot tried to test the proposed patch but the build/boot failed:

stered
[ 7.227065][ T1] io scheduler kyber registered
[ 7.230249][ T1] io scheduler bfq registered
[ 7.274282][ T1] ACPI: \_SB_.GSIE: Enabled at IRQ 20
[ 7.283915][ T1] pcieport 0000:00:04.0: PME: Signaling with IRQ 25
[ 7.291488][ T1] pcieport 0000:00:04.0: AER: enabled with IRQ 26
[ 7.301097][ T1] input: Power Button as /devices/LNXSYSTM:00/LNXPWRBN:00/input/input0
[ 7.307815][ T1] ACPI: button: Power Button [PWRF]
[ 7.590815][ T1] ioatdma: Intel(R) QuickData Technology Driver 5.00
[ 7.624170][ T1] ACPI: \_SB_.GSIF: Enabled at IRQ 21
[ 7.661185][ T1] ACPI: \_SB_.GSIH: Enabled at IRQ 23
[ 8.035591][ T1] N_HDLC line discipline registered with maxframe=4096
[ 8.039643][ T1] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
[ 8.046882][ T1] 00:04: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
[ 8.094343][ T1] Non-volatile memory driver v1.3
[ 8.103986][ T1] Linux agpgart interface v0.103
[ 8.113180][ T1] ACPI: bus type drm_connector registered
[ 8.121142][ T1] [drm] Initialized vgem 1.0.0 20120112 for vgem on minor 0
[ 8.134946][ T1] [drm] Initialized vkms 1.0.0 20180514 for vkms on minor 1
[ 8.237474][ T1] Console: switching to colour frame buffer device 128x48
[ 8.257199][ T1] platform vkms: [drm] fb0: vkmsdrmfb frame buffer device
[ 8.263052][ T1] usbcore: registered new interface driver udl
[ 8.269025][ T1] [drm] pci: virtio-vga detected at 0000:00:01.0
[ 8.274892][ T1] virtio-pci 0000:00:01.0: vgaarb: deactivate vga console
[ 8.283302][ T1] [drm] features: -virgl +edid -resource_blob -host_visible
[ 8.283317][ T1] [drm] features: -context_init
[ 8.301233][ T1] [drm] number of scanouts: 1
[ 8.304828][ T1] [drm] number of cap sets: 0
[ 8.316672][ T1] [drm] Initialized virtio_gpu 0.1.0 0 for 0000:00:01.0 on minor 2
[ 8.382391][ T1] fbcon: virtio_gpudrmfb (fb1) is primary device
[ 8.382410][ T1] fbcon: Remapping primary device, fb1, to tty 1-63
[ 8.400286][ T1] ------------[ cut here ]------------
[ 8.400336][ T1] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x17a/0x210
[ 8.400389][ T1] Modules linked in:
[ 8.400398][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-rc4-syzkaller-g7e90b5c295ec-dirty #0
[ 8.400408][ T1] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
[ 8.400414][ T1] RIP: 0010:drm_modeset_drop_locks+0x17a/0x210
[ 8.400428][ T1] Code: 00 75 39 49 8b 44 24 70 49 39 c5 0f 85 31 ff ff ff 48 83 c4 10 5b 5d 41 5c 41 5d 41 5e 41 5f e9 cc 75 83 fc e8 c7 75 83 fc 90 <0f> 0b 90 e9 c4 fe ff ff 48 89 df e8 66 9f dc fc eb 9e 4c 89 ef e8
[ 8.400437][ T1] RSP: 0000:ffffc90000047168 EFLAGS: 00010293
[ 8.400447][ T1] RAX: 0000000000000000 RBX: ffffc90000047240 RCX: ffffffff85023ebc
[ 8.400454][ T1] RDX: ffff8880166d8000 RSI: ffffffff8507d859 RDI: ffffc900000472a0
[ 8.400460][ T1] RBP: 0000000000000001 R08: 0000000000000005 R09: 0000000000000000
[ 8.400466][ T1] R10: 0000000000000004 R11: 0000000000000009 R12: ffffc90000047240
[ 8.400473][ T1] R13: dffffc0000000000 R14: 0000000000000001 R15: ffffffffffffffdd
[ 8.400483][ T1] FS: 0000000000000000(0000) GS:ffff88806b200000(0000) knlGS:0000000000000000
[ 8.400508][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 8.400518][ T1] CR2: ffff88817ffff000 CR3: 000000000d57a000 CR4: 0000000000350ef0
[ 8.400525][ T1] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 8.400531][ T1] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 8.400537][ T1] Call Trace:
[ 8.400542][ T1] <TASK>
[ 8.400547][ T1] ? show_regs+0x8f/0xa0
[ 8.400561][ T1] ? __warn+0xe6/0x390
[ 8.400575][ T1] ? drm_modeset_drop_locks+0x17a/0x210
[ 8.400587][ T1] ? report_bug+0x3c0/0x580
[ 8.400599][ T1] ? handle_bug+0x3d/0x70
[ 8.400609][ T1] ? exc_invalid_op+0x17/0x50
[ 8.400619][ T1] ? asm_exc_invalid_op+0x1a/0x20
[ 8.400662][ T1] ? drm_dev_put.part.0+0x5c/0x140
[ 8.400676][ T1] ? drm_modeset_drop_locks+0x179/0x210
[ 8.400688][ T1] ? drm_modeset_drop_locks+0x17a/0x210
[ 8.400700][ T1] ? drm_modeset_drop_locks+0x179/0x210
[ 8.400712][ T1] drm_client_modeset_commit_atomic+0x2c2/0x800
[ 8.400726][ T1] ? trace_contention_end+0xda/0x110
[ 8.400739][ T1] ? __pfx_drm_client_modeset_commit_atomic+0x10/0x10
[ 8.400753][ T1] ? __mutex_lock+0x1a6/0x9d0
[ 8.400766][ T1] ? __mutex_lock+0x1a6/0x9d0
[ 8.400780][ T1] ? __pfx___mutex_unlock_slowpath+0x10/0x10
[ 8.400798][ T1] drm_client_modeset_commit_locked+0x14d/0x580
[ 8.400812][ T1] drm_fb_helper_pan_display+0x2a5/0x990
[ 8.400824][ T1] fb_pan_display+0x477/0x7d0
[ 8.400837][ T1] ? __pfx_drm_fb_helper_pan_display+0x10/0x10
[ 8.400848][ T1] bit_update_start+0x49/0x1f0
[ 8.400860][ T1] fbcon_switch+0xbbf/0x12f0
[ 8.400871][ T1] ? __pfx_fbcon_switch+0x10/0x10
[ 8.400882][ T1] ? __pfx_bit_cursor+0x10/0x10
[ 8.400892][ T1] ? fbcon_cursor+0x3e0/0x540
[ 8.400903][ T1] ? is_console_locked+0x9/0x20
[ 8.400913][ T1] ? con_is_visible+0x65/0x150
[ 8.400926][ T1] redraw_screen+0x2bf/0x760
[ 8.400935][ T1] ? __pfx_redraw_screen+0x10/0x10
[ 8.400944][ T1] ? fb_get_color_depth+0x120/0x250
[ 8.400956][ T1] fbcon_prepare_logo+0x9f8/0xc80
[ 8.400968][ T1] set_con2fb_map+0xcf4/0x1060
[ 8.400979][ T1] fbcon_fb_registered+0x21d/0x670
[ 8.400990][ T1] ? fb_var_to_videomode+0x4c9/0x690
[ 8.401003][ T1] register_framebuffer+0x4b2/0x860
[ 8.401015][ T1] ? __pfx_register_framebuffer+0x10/0x10
[ 8.401028][ T1] ? drm_fbdev_generic_helper_fb_probe+0x4e2/0x6d0
[ 8.401038][ T1] __drm_fb_helper_initial_config_and_unlock+0xd82/0x1650
[ 8.401051][ T1] ? __pfx___drm_fb_helper_initial_config_and_unlock+0x10/0x10
[ 8.401064][ T1] drm_fb_helper_initial_config+0x44/0x60
[ 8.401075][ T1] drm_fbdev_generic_client_hotplug+0x1a6/0x280
[ 8.401085][ T1] ? __pfx_drm_fbdev_generic_client_hotplug+0x10/0x10
[ 8.401095][ T1] drm_client_register+0x195/0x280
[ 8.401107][ T1] drm_fbdev_generic_setup+0x184/0x340
[ 8.401118][ T1] virtio_gpu_probe+0x29d/0x4e0
[ 8.401131][ T1] virtio_dev_probe+0x5ff/0x9b0
[ 8.401142][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 8.401151][ T1] really_probe+0x23a/0xcb0
[ 8.401165][ T1] __driver_probe_device+0x1de/0x4b0
[ 8.401174][ T1] ? _raw_spin_unlock_irqrestore+0x52/0x80
[ 8.401187][ T1] driver_probe_device+0x4c/0x1b0
[ 8.401196][ T1] __driver_attach+0x283/0x580
[ 8.401204][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.401213][ T1] bus_for_each_dev+0x13c/0x1d0
[ 8.401225][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 8.401237][ T1] bus_add_driver+0x2ed/0x640
[ 8.401250][ T1] ? __pfx_virtio_gpu_driver_init+0x10/0x10
[ 8.401263][ T1] driver_register+0x15c/0x4b0
[ 8.401273][ T1] do_one_initcall+0x11c/0x670
[ 8.401286][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 8.401299][ T1] ? trace_kmalloc+0x2e/0xb0
[ 8.401313][ T1] ? __kmalloc+0x218/0x440
[ 8.401323][ T1] kernel_init_freeable+0x68d/0xc10
[ 8.401338][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.401349][ T1] kernel_init+0x1c/0x2a0
[ 8.401359][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.401370][ T1] ret_from_fork+0x45/0x80
[ 8.401383][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.401393][ T1] ret_from_fork_asm+0x1b/0x30
[ 8.401407][ T1] </TASK>
[ 8.401412][ T1] Kernel panic - not syncing: kernel: panic_on_warn set ...
[ 8.401417][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-rc4-syzkaller-g7e90b5c295ec-dirty #0
[ 8.401426][ T1] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
[ 8.401430][ T1] Call Trace:
[ 8.401433][ T1] <TASK>
[ 8.401436][ T1] dump_stack_lvl+0xd9/0x1b0
[ 8.401447][ T1] panic+0x6ee/0x7a0
[ 8.401458][ T1] ? __pfx_panic+0x10/0x10
[ 8.401469][ T1] ? show_trace_log_lvl+0x363/0x500
[ 8.401482][ T1] ? check_panic_on_warn+0x1f/0xb0
[ 8.401493][ T1] ? drm_modeset_drop_locks+0x17a/0x210
[ 8.401504][ T1] check_panic_on_warn+0xab/0xb0
[ 8.401516][ T1] __warn+0xf2/0x390
[ 8.401527][ T1] ? drm_modeset_drop_locks+0x17a/0x210
[ 8.401538][ T1] report_bug+0x3c0/0x580
[ 8.401547][ T1] handle_bug+0x3d/0x70
[ 8.401556][ T1] exc_invalid_op+0x17/0x50
[ 8.401565][ T1] asm_exc_invalid_op+0x1a/0x20
[ 8.401576][ T1] RIP: 0010:drm_modeset_drop_locks+0x17a/0x210
[ 8.401587][ T1] Code: 00 75 39 49 8b 44 24 70 49 39 c5 0f 85 31 ff ff ff 48 83 c4 10 5b 5d 41 5c 41 5d 41 5e 41 5f e9 cc 75 83 fc e8 c7 75 83 fc 90 <0f> 0b 90 e9 c4 fe ff ff 48 89 df e8 66 9f dc fc eb 9e 4c 89 ef e8
[ 8.401595][ T1] RSP: 0000:ffffc90000047168 EFLAGS: 00010293
[ 8.401602][ T1] RAX: 0000000000000000 RBX: ffffc90000047240 RCX: ffffffff85023ebc
[ 8.401607][ T1] RDX: ffff8880166d8000 RSI: ffffffff8507d859 RDI: ffffc900000472a0
[ 8.401612][ T1] RBP: 0000000000000001 R08: 0000000000000005 R09: 0000000000000000
[ 8.401617][ T1] R10: 0000000000000004 R11: 0000000000000009 R12: ffffc90000047240
[ 8.401622][ T1] R13: dffffc0000000000 R14: 0000000000000001 R15: ffffffffffffffdd
[ 8.401628][ T1] ? drm_dev_put.part.0+0x5c/0x140
[ 8.401640][ T1] ? drm_modeset_drop_locks+0x179/0x210
[ 8.401651][ T1] ? drm_modeset_drop_locks+0x179/0x210
[ 8.401662][ T1] drm_client_modeset_commit_atomic+0x2c2/0x800
[ 8.401674][ T1] ? trace_contention_end+0xda/0x110
[ 8.401685][ T1] ? __pfx_drm_client_modeset_commit_atomic+0x10/0x10
[ 8.401697][ T1] ? __mutex_lock+0x1a6/0x9d0
[ 8.401709][ T1] ? __mutex_lock+0x1a6/0x9d0
[ 8.401721][ T1] ? __pfx___mutex_unlock_slowpath+0x10/0x10
[ 8.401734][ T1] drm_client_modeset_commit_locked+0x14d/0x580
[ 8.401746][ T1] drm_fb_helper_pan_display+0x2a5/0x990
[ 8.401756][ T1] fb_pan_display+0x477/0x7d0
[ 8.401766][ T1] ? __pfx_drm_fb_helper_pan_display+0x10/0x10
[ 8.401776][ T1] bit_update_start+0x49/0x1f0
[ 8.401786][ T1] fbcon_switch+0xbbf/0x12f0
[ 8.401799][ T1] ? __pfx_fbcon_switch+0x10/0x10
[ 8.401808][ T1] ? __pfx_bit_cursor+0x10/0x10
[ 8.401818][ T1] ? fbcon_cursor+0x3e0/0x540
[ 8.401827][ T1] ? is_console_locked+0x9/0x20
[ 8.401836][ T1] ? con_is_visible+0x65/0x150
[ 8.401847][ T1] redraw_screen+0x2bf/0x760
[ 8.401854][ T1] ? __pfx_redraw_screen+0x10/0x10
[ 8.401862][ T1] ? fb_get_color_depth+0x120/0x250
[ 8.401873][ T1] fbcon_prepare_logo+0x9f8/0xc80
[ 8.401883][ T1] set_con2fb_map+0xcf4/0x1060
[ 8.401893][ T1] fbcon_fb_registered+0x21d/0x670
[ 8.401902][ T1] ? fb_var_to_videomode+0x4c9/0x690
[ 8.401914][ T1] register_framebuffer+0x4b2/0x860
[ 8.401925][ T1] ? __pfx_register_framebuffer+0x10/0x10
[ 8.401936][ T1] ? drm_fbdev_generic_helper_fb_probe+0x4e2/0x6d0
[ 8.401945][ T1] __drm_fb_helper_initial_config_and_unlock+0xd82/0x1650
[ 8.401956][ T1] ? __pfx___drm_fb_helper_initial_config_and_unlock+0x10/0x10
[ 8.401968][ T1] drm_fb_helper_initial_config+0x44/0x60
[ 8.401977][ T1] drm_fbdev_generic_client_hotplug+0x1a6/0x280
[ 8.401986][ T1] ? __pfx_drm_fbdev_generic_client_hotplug+0x10/0x10
[ 8.401994][ T1] drm_client_register+0x195/0x280
[ 8.402005][ T1] drm_fbdev_generic_setup+0x184/0x340
[ 8.402014][ T1] virtio_gpu_probe+0x29d/0x4e0
[ 8.402025][ T1] virtio_dev_probe+0x5ff/0x9b0
[ 8.402033][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 8.402041][ T1] really_probe+0x23a/0xcb0
[ 8.402053][ T1] __driver_probe_device+0x1de/0x4b0
[ 8.402061][ T1] ? _raw_spin_unlock_irqrestore+0x52/0x80
[ 8.402072][ T1] driver_probe_device+0x4c/0x1b0
[ 8.402080][ T1] __driver_attach+0x283/0x580
[ 8.402088][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.402095][ T1] bus_for_each_dev+0x13c/0x1d0
[ 8.402106][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 8.402116][ T1] bus_add_driver+0x2ed/0x640
[ 8.402128][ T1] ? __pfx_virtio_gpu_driver_init+0x10/0x10
[ 8.402138][ T1] driver_register+0x15c/0x4b0
[ 8.402147][ T1] do_one_initcall+0x11c/0x670
[ 8.402158][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 8.402169][ T1] ? trace_kmalloc+0x2e/0xb0
[ 8.402181][ T1] ? __kmalloc+0x218/0x440
[ 8.402190][ T1] kernel_init_freeable+0x68d/0xc10
[ 8.402203][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.402212][ T1] kernel_init+0x1c/0x2a0
[ 8.402221][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.402230][ T1] ret_from_fork+0x45/0x80
[ 8.402241][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.402251][ T1] ret_from_fork_asm+0x1b/0x30
[ 8.402263][ T1] </TASK>
[ 8.403059][ T1] Kernel Offset: disabled


syzkaller build log:
go env (err=<nil>)
GO111MODULE="auto"
GOARCH="amd64"
GOBIN=""
GOCACHE="/syzkaller/.cache/go-build"
GOENV="/syzkaller/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/syzkaller/jobs/linux/gopath/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/syzkaller/jobs/linux/gopath"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct";
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/syzkaller/jobs/linux/gopath/src/github.com/google/syzkaller/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build253358196=/tmp/go-build -gno-record-gcc-switches"

git status (err=<nil>)
HEAD detached at e66542d78
nothing to commit, working tree clean


tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:32: run command via tools/syz-env for best compatibility, see:
Makefile:33: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
go list -f '{{.Stale}}' ./sys/syz-sysgen | grep -q false || go install ./sys/syz-sysgen
make .descriptions
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
bin/syz-sysgen
touch .descriptions
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=e66542d78f1cf0c783877440cd239a11fb73fb15 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240213-111349'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-fuzzer github.com/google/syzkaller/syz-fuzzer
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=e66542d78f1cf0c783877440cd239a11fb73fb15 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240213-111349'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-execprog github.com/google/syzkaller/tools/syz-execprog
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=e66542d78f1cf0c783877440cd239a11fb73fb15 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240213-111349'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-stress github.com/google/syzkaller/tools/syz-stress
mkdir -p ./bin/linux_amd64
gcc -o ./bin/linux_amd64/syz-executor executor/executor.cc \
-m64 -O2 -pthread -Wall -Werror -Wparentheses -Wunused-const-variable -Wframe-larger-than=16384 -Wno-stringop-overflow -Wno-array-bounds -Wno-format-overflow -Wno-unused-but-set-variable -Wno-unused-command-line-argument -static-pie -fpermissive -w -DGOOS_linux=1 -DGOARCH_amd64=1 \
-DHOSTGOOS_linux=1 -DGIT_REVISION=\"e66542d78f1cf0c783877440cd239a11fb73fb15\"


Error text is too large and was truncated, full error text is at:
https://syzkaller.appspot.com/x/error.txt?x=1395d592180000


Tested on:

commit: 7e90b5c2 Merge tag 'trace-tools-v6.8-rc4' of git://git..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
kernel config: https://syzkaller.appspot.com/x/.config?x=df82262440d95bc4
dashboard link: https://syzkaller.appspot.com/bug?extid=0f999d26a4fd79c3a23b
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=1247ec62180000