RE: [PATCH v3] EDAC/versal: Make the bits in error injection configurable

[Datta, Shubhrajyoti]

[AMD Official Use Only - General]

> -----Original Message-----
> From: Borislav Petkov <bp@xxxxxxxxx>
> Sent: Wednesday, February 14, 2024 12:05 AM
> To: Datta, Shubhrajyoti <shubhrajyoti.datta@xxxxxxx>
> Cc: linux-edac@xxxxxxxxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx>; Potthuri,
> Sai Krishna <sai.krishna.potthuri@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> tony.luck@xxxxxxxxx; james.morse@xxxxxxx; mchehab@xxxxxxxxxx;
> rric@xxxxxxxxxx
> Subject: Re: [PATCH v3] EDAC/versal: Make the bits in error injection
> configurable
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Thu, Feb 08, 2024 at 03:16:53PM +0530, Shubhrajyoti Datta wrote:
> > Currently the error injection for correctable and uncorrectable errors
> > bits are hardcoded. To make it configurable add separate sysfs entries
> > to set the bit positions for injecting CE and UE errors.
> > It injects single bit error for CE and two bits errors for UE.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxx>
> > ---
>
> Did some touchups ontop, especially make inject_data_ce_store() verify the
> user input first and then do the injection, just like the ue_store counterpart
> does.
>
> Pls check whether injection still works ok.
>
Thanks tested it working fine .

Thanks ,
Shubhrajyoti