RE: [PATCH v5 1/2] KVM: VMX: Cleanup VMX basic information defines and usages

[Li, Xin3]

> > I see your point here.  But "#define VMX_EPTP_MT_WB	0x6ull" seems to
> define
> > its own memory type 0x6.  I think what we want is:
> >
> > /* in a pat/mtrr header */
> > #define MEM_TYPE_WB 0x6
> >
> > /* vmx.h */
> > #define VMX_EPTP_MT_WB	MEM_TYPE_WB
> >
> > if it's not regarded as another layer of indirect.
> 
> Heh, yep, I already had this:
> 
> /* The EPTP memtype is encoded in bits 2:0, i.e. doesn't need to be shifted. */
> #define VMX_EPTP_MT_MASK			0x7ull
> #define VMX_EPTP_MT_WB				X86_MEMTYPE_WB
> #define VMX_EPTP_MT_UC				X86_MEMTYPE_UC

Perfect!