Re: [PATCH v2 3/4] iio: magnetometer: add a driver for Voltafield AF8133J magnetometer

From: Andrey Skvortsov
Date: Tue Feb 13 2024 - 16:25:59 EST


Hi Ondřej,

thank you for submitting the driver.

On 24-02-12 18:53, Ondřej Jirman wrote:
> From: Icenowy Zheng <icenowy@xxxxxxx>
>
> AF8133J is a simple I2C-connected magnetometer, without interrupts.
>
> Add a simple IIO driver for it.
>
> Co-developed-by: Icenowy Zheng <icenowy@xxxxxxx>
> Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
> Signed-off-by: Dalton Durst <dalton@xxxxxxxxxxx>
> Signed-off-by: Shoji Keita <awaittrot@xxxxxxx>
> Co-developed-by: Ondrej Jirman <megi@xxxxxx>
> Signed-off-by: Ondrej Jirman <megi@xxxxxx>
> ---
> drivers/iio/magnetometer/Kconfig | 12 +
> drivers/iio/magnetometer/Makefile | 1 +
> drivers/iio/magnetometer/af8133j.c | 528 +++++++++++++++++++++++++++++
> 3 files changed, 541 insertions(+)
> create mode 100644 drivers/iio/magnetometer/af8133j.c
>
> diff --git a/drivers/iio/magnetometer/Kconfig b/drivers/iio/magnetometer/Kconfig
> index 38532d840f2a..cd2917d71904 100644
> --- a/drivers/iio/magnetometer/Kconfig
> +++ b/drivers/iio/magnetometer/Kconfig
> @@ -6,6 +6,18 @@
>

Reviewed-by: Andrey Skvortsov <andrej.skvortzov@xxxxxxxxx>

I've successfully tested driver from v2 on 6.8-rc3.

--
Best regards,
Andrey Skvortsov