Re: [PATCH v2 1/1] spi-mxs: Fix chipselect glitch

From: Fabio Estevam
Date: Tue Feb 13 2024 - 12:23:12 EST


Hi Ralf,

On Tue, Feb 13, 2024 at 2:07 PM Ralf Schlatterbeck <rsc@xxxxxxxxxx> wrote:
>
> On Fri, Feb 02, 2024 at 12:53:30PM +0100, Ralf Schlatterbeck wrote:
> > There was a change in the mxs-dma engine that uses a new custom flag.
> > The change was not applied to the mxs spi driver.
> > This results in chipselect being deasserted too early.
> > This fixes the chipselect problem by using the new flag in the mxs-spi
> > driver.
> >
> > Fixes: ceeeb99cd821 ("dmaengine: mxs: rename custom flag")
> > Signed-off-by: Ralf Schlatterbeck <rsc@xxxxxxxxxx>
> > ---
> > For oscilloscope screenshots and a verbose explanation see my blog post
> > at https://blog.runtux.com/posts/2024/02/01/

I suggest putting the link to your detailed explanation into the
commit log as this is useful information.

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>