Re: [PATCH] mm: memcontrol: clarify swapaccount=0 deprecation warning

From: Shakeel Butt
Date: Tue Feb 13 2024 - 12:02:09 EST


On Tue, Feb 13, 2024 at 12:16 AM Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
>
> The swapaccount deprecation warning is throwing false positives. Since
> we deprecated the knob and defaulted to enabling, the only reports
> we've been getting are from folks that set swapaccount=1. While this
> is a nice affirmation that always-enabling was the right choice, we
> certainly don't want to warn when users request the supported mode.
>
> Only warn when disabling is requested, and clarify the warning.
>
> Fixes: b25806dcd3d5 ("mm: memcontrol: deprecate swapaccounting=0 mode")
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: "Jonas Schäfer" <jonas@xxxxxxxxxxxxx>
> Reported-by: Narcis Garcia <debianlists@xxxxxxxxx>
> Suggested-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx>
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Acked-by: Shakeel Butt <shakeelb@xxxxxxxxxx>