Re: [PATCH v8 4/5] mm,page_owner: Filter out stacks by a threshold

[Vlastimil Babka]

On 2/13/24 10:21, Oscar Salvador wrote:
> On Tue, Feb 13, 2024 at 09:44:47AM +0100, Marco Elver wrote:
>> On Mon, 12 Feb 2024 at 23:29, Oscar Salvador <osalvador@xxxxxxx>
>> wrote:
>>> +       debugfs_create_file("set_threshold", 0600, dir, NULL, +
>>> &proc_page_owner_threshold);
>> 
>> Can't you also read from "set_threshold", so the name "set_threshold" 
>> is misleading. Why not just "threshold"?
> 
> Yes, it can also be read. I guess I was too focused on the set part.

Maybe name it "count_threshold" so it's more clear of whate exactly it's the
threshold of?

> I will rename that one, plus add the {READ,WRITE}_ONCE.
> 
> Thanks!
>