Re: [PATCH 07/12] memory: stm32-fmc2-ebi: add runtime PM support

[Christophe Kerello]

On 2/13/24 08:59, Krzysztof Kozlowski wrote:
> On 12/02/2024 18:48, Christophe Kerello wrote:
> > Add runtime PM support in FMC2 ebi driver to be able to manage GENPD
> > support when it will be enabled.

Hi Krzysztof,

> You don't do any real runtime PM here (turning on PM domain on probe is
> not real PM), so please explain what is the goal of it and say that it
> is basic RPM for keeping domain on.

Yes, you are true, I will modify the commit message.

> > Signed-off-by: Christophe Kerello <christophe.kerello@xxxxxxxxxxx>
> > ---
> >   drivers/memory/stm32-fmc2-ebi.c | 40 ++++++++++++++++++++++++++-------
> >   1 file changed, 32 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/memory/stm32-fmc2-ebi.c b/drivers/memory/stm32-fmc2-ebi.c
> > index 04248c15832f..8c30e56be3b0 100644
> > --- a/drivers/memory/stm32-fmc2-ebi.c
> > +++ b/drivers/memory/stm32-fmc2-ebi.c
> > @@ -11,6 +11,7 @@
> >   #include <linux/of_platform.h>
> >   #include <linux/pinctrl/consumer.h>
> >   #include <linux/platform_device.h>
> > +#include <linux/pm_runtime.h>
> >   #include <linux/regmap.h>
> >   #include <linux/reset.h>
> >   
> > @@ -1381,6 +1382,7 @@ static int stm32_fmc2_ebi_probe(struct platform_device *pdev)
> >   		return -ENOMEM;
> >   
> >   	ebi->dev = dev;
> > +	platform_set_drvdata(pdev, ebi);
>
> Does not look related.

With pm_runtime_resume_and_get API now called, 
stm32_fmc2_ebi_runtime_resume needs ebi data to enable the clock. It
means that the platform data has to be set before this call.

Regards,
Christophe Kerello.

> Best regards,
> Krzysztof