Re: [PATCH 08/12] dt-bindings: mtd: st,stm32: add MP25 support

[Christophe Kerello]

On 2/12/24 19:38, Conor Dooley wrote:
> On Mon, Feb 12, 2024 at 06:48:18PM +0100, Christophe Kerello wrote:
> > Add 2 new compatible strings to support MP25 SOC.
> > MP25 SOC supports up to 4 chip select.
>
> Again, please explain why the new device is not compatible with the
> existing ones. Also, please explain why two compatibles are required for
> the mp25.

Hi Conor,

FMC2 IP supports up to 4 chip select. On MP1 SoC, only 2 of them are 
available when on MP25 SoC, the 4 chip select are available.

MP1 SoC also embeds revision 1.1 of the FMC2 IP when MP25 SoC embeds 
revision 2.0 of the FMC2 IP.

I will add this explanation in the commit message.

Regards,
Christophe Kerello.

> Thanks,
> Conor.
>
> > Signed-off-by: Christophe Kerello <christophe.kerello@xxxxxxxxxxx>
> > ---
> >   .../bindings/mtd/st,stm32-fmc2-nand.yaml      | 58 ++++++++++++++++++-
> >   1 file changed, 57 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml b/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml
> > index e72cb5bacaf0..33a753c8877b 100644
> > --- a/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml
> > @@ -14,10 +14,12 @@ properties:
> >       enum:
> >         - st,stm32mp15-fmc2
> >         - st,stm32mp1-fmc2-nfc
> > +      - st,stm32mp25-fmc2
> > +      - st,stm32mp25-fmc2-nfc
> >   
> >     reg:
> >       minItems: 6
> > -    maxItems: 7
> > +    maxItems: 13
> >   
> >     interrupts:
> >       maxItems: 1
> > @@ -92,6 +94,60 @@ allOf:
> >               - description: Chip select 1 command
> >               - description: Chip select 1 address space
> >   
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: st,stm32mp25-fmc2
> > +    then:
> > +      properties:
> > +        reg:
> > +          items:
> > +            - description: Registers
> > +            - description: Chip select 0 data
> > +            - description: Chip select 0 command
> > +            - description: Chip select 0 address space
> > +            - description: Chip select 1 data
> > +            - description: Chip select 1 command
> > +            - description: Chip select 1 address space
> > +            - description: Chip select 2 data
> > +            - description: Chip select 2 command
> > +            - description: Chip select 2 address space
> > +            - description: Chip select 3 data
> > +            - description: Chip select 3 command
> > +            - description: Chip select 3 address space
> > +
> > +        clocks:
> > +          maxItems: 1
> > +
> > +        resets:
> > +          maxItems: 1
> > +
> > +      required:
> > +        - clocks
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: st,stm32mp25-fmc2-nfc
> > +    then:
> > +      properties:
> > +        reg:
> > +          items:
> > +            - description: Chip select 0 data
> > +            - description: Chip select 0 command
> > +            - description: Chip select 0 address space
> > +            - description: Chip select 1 data
> > +            - description: Chip select 1 command
> > +            - description: Chip select 1 address space
> > +            - description: Chip select 2 data
> > +            - description: Chip select 2 command
> > +            - description: Chip select 2 address space
> > +            - description: Chip select 3 data
> > +            - description: Chip select 3 command
> > +            - description: Chip select 3 address space
> > +
> >   required:
> >     - compatible
> >     - reg
> > --
> > 2.25.1