Re: [syzbot] [ntfs3?] possible deadlock in ntfs_set_state (2)

From: Edward Adam Davis
Date: Tue Feb 13 2024 - 05:44:07 EST


please test deadlock in ntfs_set_state

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
index 3b42938a9d3b..1dfc933b58ad 100644
--- a/fs/ntfs3/frecord.c
+++ b/fs/ntfs3/frecord.c
@@ -3210,7 +3210,6 @@ static bool ni_update_parent(struct ntfs_inode *ni, struct NTFS_DUP_INFO *dup,

/* Check simple case when parent inode equals current inode. */
if (ino_get(&fname->home) == ni->vfs_inode.i_ino) {
- ntfs_set_state(sbi, NTFS_DIRTY_ERROR);
continue;
}