Re: [PATCH 2/2] leds: Add NCP5623 multi-led driver
From: Pavel Machek
Date: Tue Feb 13 2024 - 04:18:59 EST
Hi!
> .../sysfs-class-led-multicolor-driver-ncp5623 | 46 +++
> drivers/leds/rgb/Kconfig | 11 +
> drivers/leds/rgb/Makefile | 1 +
> drivers/leds/rgb/leds-ncp5623.c | 320 ++++++++++++++++++
> 4 files changed, 378 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp5623
> create mode 100644 drivers/leds/rgb/leds-ncp5623.c
>
> diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp5623 b/Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp5623
> new file mode 100644
> index 000000000000..6b9f4849852b
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp5623
> @@ -0,0 +1,46 @@
> +What: /sys/class/leds/<led>/direction
> +Date: Feb 2024
> +What: /sys/class/leds/<led>/dim_step
You are reinventing hardware_pattern trigger. NAK.
I suggest you add basic support first, then look at hardware pattern
trigger and add that support in separate patch.
Thanks,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature