Re: [PATCH v1 07/14] dt-bindings: lcdif: Do not require power-domains for i.MX6ULL

From: Stefan Wahren
Date: Tue Feb 13 2024 - 03:58:22 EST


Hi Sebastian,

Am 13.02.24 um 00:10 schrieb Sebastian Reichel:
Hi Stefan,

On Mon, Feb 12, 2024 at 08:20:35PM +0100, Stefan Wahren wrote:
Am 10.02.24 um 02:18 schrieb Sebastian Reichel:
i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string,
but has only very lightweight DISPLAY power domain. Its DISPLAY
power domain is not supported by the binding / Linux kernel at
the moment. Since the current setup is working, let's remove the
power-domain from being required for that platform to fix the warning
printed by CHECK_DTBS=y.
i'm not sure this is a good idea. In case i.MX6UL(L) is different from
i.MX6SX here, then it should have a different compatible.
It already has. The i.MX6UL(L) compatible looks like this:

compatible = "fsl,imx6ul-lcdif", "fsl,imx6sx-lcdif"

So the i.MX6SX one is just a fallback compatible. But the current
requirement for power-domains affects i.MX6UL(L), since it says
the compatible only needs to contain "fsl,imx6sx-lcdif" somewhere
to make power-domains mandatory.
thanks, i misunderstood the commit message. I thought this was a
i.MX6UL(L) specific issue and the i.MX6SX is slightly different. In the
past the fallback compatible was sometimes abused.

So everything makes sense now.
Note, that the kernel driver does not use "fsl,imx6ul-lcdif", so
the hardware itself is indeed compatible.

-- Sebastian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel