Re: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of depending on it

From: Arnd Bergmann
Date: Tue Feb 13 2024 - 03:27:20 EST


On Tue, Feb 13, 2024, at 07:00, Randy Dunlap wrote:
> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
> it directly thru "make *config", so drivers should select it instead
> of depending on it if they need it.
> Relying on it being set for a dependency is risky.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change EXTCON_MAX8997's use of "depends on" for
> IRQ_DOMAIN to "select".
>
> Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>