Re: [PATCH 1/6] fs: iomap: Atomic write support

From: Christoph Hellwig
Date: Tue Feb 13 2024 - 01:55:34 EST


On Mon, Feb 05, 2024 at 11:29:57AM +0000, John Garry wrote:
>>
>> Also, what's the meaning of REQ_OP_READ | REQ_ATOMIC?
>
> REQ_ATOMIC will be ignored for REQ_OP_READ. I'm following the same policy
> as something like RWF_SYNC for a read.

We've been rather sloppy with these flags in the past, which isn't
a good thing. Let's add proper checking for new interfaces.