Re: [PATCH] Fix MODULE_AUTHORs' missing closing >s

From: Joe Perches
Date: Mon Feb 12 2024 - 23:12:34 EST


On Tue, 2024-02-13 at 03:52 +0100, Ahelenia Ziemiańska wrote:
> When perusing arch/mips/crypto/crc32-mips.c I noticed that Marcin's
> MODULE_AUTHOR string was damaged; there's quite a few of these.
>
> Automatically found with
> git grep 'MODULE_AUTHOR.*<[^>]*[^>],'
> git grep 'MODULE_AUTHOR.*<[^>]*[^>]")'
> and fixed with
> vi drivers/media/dvb-frontends/dib8000.c
> sed -i '/MODULE_AUTHOR.*<[^>]*[^>]")/s/")/>")/' \
> $(git grep -l 'MODULE_AUTHOR.*<[^>]*[^>]")')

Maybe change these to use angle brackets instead
of parentheses for the email address as well?

$ git grep -P 'MODULE_AUTHOR\s*\(\s*"[^"\(]+\([^"\)]+@[^"\)]+\)'
arch/sparc/kernel/chmc.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
arch/sparc/kernel/ds.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/block/sunvdc.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/char/hw_random/n2-drv.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/char/tpm/st33zp24/i2c.c:MODULE_AUTHOR("TPM support (TPMsupport@xxxxxxxxxx)");
drivers/char/tpm/st33zp24/spi.c:MODULE_AUTHOR("TPM support (TPMsupport@xxxxxxxxxx)");
drivers/char/tpm/st33zp24/st33zp24.c:MODULE_AUTHOR("TPM support (TPMsupport@xxxxxxxxxxx)");
drivers/char/tpm/tpm-interface.c:MODULE_AUTHOR("Leendert van Doorn (leendert@xxxxxxxxxxxxxx)");
drivers/char/tpm/tpm_atmel.c:MODULE_AUTHOR("Leendert van Doorn (leendert@xxxxxxxxxxxxxx)");
drivers/char/tpm/tpm_i2c_nuvoton.c:MODULE_AUTHOR("Dan Morav (dan.morav@xxxxxxxxxxx)");
drivers/char/tpm/tpm_nsc.c:MODULE_AUTHOR("Leendert van Doorn (leendert@xxxxxxxxxxxxxx)");
drivers/char/tpm/tpm_tis.c:MODULE_AUTHOR("Leendert van Doorn (leendert@xxxxxxxxxxxxxx)");
drivers/char/tpm/tpm_tis_core.c:MODULE_AUTHOR("Leendert van Doorn (leendert@xxxxxxxxxxxxxx)");
drivers/char/tpm/tpm_vtpm_proxy.c:MODULE_AUTHOR("Stefan Berger (stefanb@xxxxxxxxxx)");
drivers/crypto/n2_core.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/hwmon/dell-smm-hwmon.c:MODULE_AUTHOR("Massimo Dal Zotto (dz@xxxxxxxxxx)");
drivers/hwmon/ultra45_env.c:MODULE_AUTHOR("David S. Miller (davem@davemloftnet)");
drivers/i2c/muxes/i2c-mux-mlxcpld.c:MODULE_AUTHOR("Michael Shych (michaels@xxxxxxxxxxxx)");
drivers/leds/leds-sunfire.c:MODULE_AUTHOR("David S. Miller (davem@davemloftnet)");
drivers/media/common/siano/smscoreapi.c:MODULE_AUTHOR("Siano Mobile Silicon, Inc. (uris@xxxxxxxxxxxx)");
drivers/media/common/siano/smsdvb-main.c:MODULE_AUTHOR("Siano Mobile Silicon, Inc. (uris@xxxxxxxxxxxx)");
drivers/media/dvb-frontends/cx24117.c:MODULE_AUTHOR("Luis Alves (ljalvs@xxxxxxxxx)");
drivers/media/usb/siano/smsusb.c:MODULE_AUTHOR("Siano Mobile Silicon, INC. (uris@xxxxxxxxxxxx)");
drivers/net/ethernet/broadcom/tg3.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxx) and Jeff Garzik (jgarzik@xxxxxxxxx)");
drivers/net/ethernet/sun/cassini.c:MODULE_AUTHOR("Adrian Sun (asun@xxxxxxxxxxxxxxxxx)");
drivers/net/ethernet/sun/niu.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/net/ethernet/sun/sunhme.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/net/ethernet/sun/sunvnet.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/net/ethernet/sun/sunvnet_common.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/net/ppp/pptp.c:MODULE_AUTHOR("D. Kozlov (xeb@xxxxxxx)");
drivers/platform/x86/compal-laptop.c:MODULE_AUTHOR("Roald Frederickx (roaldfrederickx@xxxxxxxxx)");
drivers/platform/x86/intel/oaktrail.c:MODULE_AUTHOR("Yin Kangkai (kangkai.yin@xxxxxxxxx)");
drivers/platform/x86/mlx-platform.c:MODULE_AUTHOR("Vadim Pasternak (vadimp@xxxxxxxxxxxx)");
drivers/sbus/char/openprom.c:MODULE_AUTHOR("Thomas K. Dyas (tdyas@xxxxxxxxxxxxxxx) and Eddie C. Dost (ecd@xxxxxxxxx)");
drivers/scsi/esp_scsi.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/scsi/jazz_esp.c:MODULE_AUTHOR("Thomas Bogendoerfer (tsbogend@xxxxxxxxxxxxxxxx)");
drivers/scsi/mesh.c:MODULE_AUTHOR("Paul Mackerras (paulus@xxxxxxxxx)");
drivers/scsi/qlogicpti.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/scsi/sun3x_esp.c:MODULE_AUTHOR("Thomas Bogendoerfer (tsbogend@xxxxxxxxxxxxxxx)");
drivers/scsi/sun_esp.c:MODULE_AUTHOR("David S. Miller (davem@xxxxxxxxxxxxx)");
drivers/video/fbdev/hgafb.c:MODULE_AUTHOR("Ferenc Bakonyi (fero@xxxxxxxxxxxxxxxxxxx)");
net/ipv4/gre_demux.c:MODULE_AUTHOR("D. Kozlov (xeb@xxxxxxx)");
net/ipv6/ip6_gre.c:MODULE_AUTHOR("D. Kozlov (xeb@xxxxxxx)");
net/mpls/mpls_gso.c:MODULE_AUTHOR("Simon Horman (horms@xxxxxxxxxxxx)");