Re: [PATCHv3] PPPoL2TP: Add more code snippets

[Tom Parkin]

On  Fri, Feb 09, 2024 at 08:20:46 -0800, Jakub Kicinski wrote:
> On Sat, 3 Feb 2024 23:35:13 +0100 Samuel Thibault wrote:
> > The existing documentation was not telling that one has to create a PPP
> > channel and a PPP interface to get PPPoL2TP data offloading working.
> > 
> > Also, tunnel switching was not mentioned, so that people were thinking
> > it was not supported, while it actually is.
> > 
> > Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> 
> James, Tom, looks good?

Sorry for the silence -- I think for v2 we had some discussion of
whether the PPPIOCBRIDGECHAN docs really belonged in l2tp.rst or not
and I wasn't sure whether the same issue would be raised again.

For me I'm happy enough having it mentioned in the l2tp documentation,
so long as the example is clear and accurate.  I've responded to the
patch now with a couple of suggestions on that front.

Thanks,
Tom
-- 
Tom Parkin
Katalix Systems Ltd
https://katalix.com
Catalysts for your Embedded Linux software development

Attachment: signature.asc
Description: PGP signature