Re: [PATCH v2 1/2] ACPI: use %pe for better readability of errors while printing

From: Bjorn Helgaas
Date: Mon Feb 12 2024 - 14:29:43 EST

On Mon, Feb 12, 2024 at 03:54:03PM +0530, Onkarnarth wrote:
> From: Onkarnath <onkarnath.1@xxxxxxxxxxx>
> As %pe is already introduced, it's better to use it in place of (%ld) for
> printing errors in logs. It would enhance readability of logs.
> Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx>
> Signed-off-by: Onkarnath <onkarnath.1@xxxxxxxxxxx>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
> Reviewed-by: Bjorn Helgaas <helgaas@xxxxxxxxxx>

This tag is wrong. I provided some feedback, but that's not the same
as providing a "Reviewed-by" tag. "Reviewed-by" has a very specific
meaning and the reviewer must provide it explicitly; details here: