Re: [PATCH 02/12] dt-bindings: memory-controller: st,stm32: add 'power-domains' property

From: Conor Dooley
Date: Mon Feb 12 2024 - 13:34:31 EST


On Mon, Feb 12, 2024 at 06:48:12PM +0100, Christophe Kerello wrote:
> From: Patrick Delaunay <patrick.delaunay@xxxxxxxxxxx>
>
> On STM32MP25 SOC, STM32 FMC2 memory controller is in a power domain.
> Allow a single 'power-domains' entry for STM32 FMC2.

This should be squashed with patch 1, since they both modify the same
file and this power-domain is part of the addition of mp25 support.

If the mp1 doesn't have power domains, shouldn't you constrain the
property to mp25 only?

Cheers,
Conor.

>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@xxxxxxxxxxx>
> Signed-off-by: Christophe Kerello <christophe.kerello@xxxxxxxxxxx>
> ---
> .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
> index 12e6afeceffd..84ac6f50a6fc 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
> @@ -36,6 +36,9 @@ properties:
> resets:
> maxItems: 1
>
> + power-domains:
> + maxItems: 1
> +
> "#address-cells":
> const: 2
>
> --
> 2.25.1
>

Attachment: signature.asc
Description: PGP signature