Re: [PATCH] sh: Fix build with CONFIG_UBSAN=y

From: Kees Cook
Date: Mon Feb 12 2024 - 13:26:16 EST


On Sun, Feb 11, 2024 at 11:39:49AM +0100, John Paul Adrian Glaubitz wrote:
> Hi Kees,
>
> On Fri, 2024-02-02 at 12:06 +0100, John Paul Adrian Glaubitz wrote:
> > > When I use GCC 13.2 (I'm specifically on Ubuntu 23.10) and the randconfig
> > > linked from the report:
> > > https://download.01.org/0day-ci/archive/20240131/202401310416.s8HLiLnC-lkp@xxxxxxxxx/config
> > > (which is notably enabling CONFIG_UBSAN=y and CONFIG_UBSAN_SHIFT=y) then I
> > > see at the final link stage:
> > >
> > > /usr/bin/sh4-linux-gnu-ld: arch/sh/boot/compressed/misc.o: in function `zlib_inflate_table':
> > > misc.c:(.text+0x650): undefined reference to `__ubsan_handle_shift_out_of_bounds'
> > > ...
> > >
> > > After the patch, it's solved.
> >
> > OK, let me test with gcc 13.x. My build host is currently running openSUSE Leap 15.5.
>
> I just wanted to try reproduce the problem again with the reproducer in [1] as well
> as with gcc-13.2.0, but your branch devel/overflow/ubsan-only no longer exists.
>
> Can you tell me where to find the patches now?

Sure, they're in -next, but for an -rc2 based tree, see:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/kspp

--
Kees Cook