Re: [patch v5 13/19] x86/mm/numa: Use core domain size on AMD

[Borislav Petkov]

On Tue, Jan 23, 2024 at 01:53:50PM +0100, Thomas Gleixner wrote:
> @@ -158,26 +156,25 @@ int __init amd_numa_init(void)
>  		return -ENOENT;
>  
>  	/*
> -	 * We seem to have valid NUMA configuration.  Map apicids to nodes
> -	 * using the coreid bits from early_identify_cpu.
> +	 * We seem to have valid NUMA configuration. Map apicids to nodes
> +	 * using the size of the core domain in the APIC space.

Since you're touching the comments:

	/*
	 * Valid NUMA configuration detected. Map APICIDs to nodes...

>  	 */
> -	bits = boot_cpu_data.x86_coreid_bits;
> -	cores = 1 << bits;
> -	apicid_base = 0;
> +	cores = topology_get_domain_size(TOPO_CORE_DOMAIN);

num_cores ...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette