Re: [PATCH v1 -next 0/3] RISC-V: ACPI: Enable CPPC based cpufreq support

From: Rafael J. Wysocki
Date: Mon Feb 12 2024 - 10:24:41 EST


On Thu, Feb 8, 2024 at 4:44 AM Sunil V L <sunilvl@xxxxxxxxxxxxxxxx> wrote:
>
> This series enables the support for "Collaborative Processor Performance
> Control (CPPC) on ACPI based RISC-V platforms. It depends on the
> encoding of CPPC registers as defined in RISC-V FFH spec [2].
>
> CPPC is described in the ACPI spec [1]. RISC-V FFH spec required to
> enable this, is available at [2].
>
> [1] - https://uefi.org/specs/ACPI/6.5/08_Processor_Configuration_and_Control.html#collaborative-processor-performance-control
> [2] - https://github.com/riscv-non-isa/riscv-acpi-ffh/releases/download/v1.0.0/riscv-ffh.pdf
>
> The series is based on the LPI support series.
> Based-on: 20240118062930.245937-1-sunilvl@xxxxxxxxxxxxxxxx
> (https://lore.kernel.org/lkml/20240118062930.245937-1-sunilvl@xxxxxxxxxxxxxxxx/)
>
> Sunil V L (3):
> ACPI: RISC-V: Add CPPC driver
> cpufreq: Move CPPC configs to common Kconfig and add RISC-V
> RISC-V: defconfig: Enable CONFIG_ACPI_CPPC_CPUFREQ
>
> arch/riscv/configs/defconfig | 1 +
> drivers/acpi/riscv/Makefile | 1 +
> drivers/acpi/riscv/cppc.c | 157 +++++++++++++++++++++++++++++++++++
> drivers/cpufreq/Kconfig | 29 +++++++
> drivers/cpufreq/Kconfig.arm | 26 ------
> 5 files changed, 188 insertions(+), 26 deletions(-)
> create mode 100644 drivers/acpi/riscv/cppc.c
>
> --

This is fine with me, so

Acked-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>

and it would be good to ask Viresh (who maintains the CPPC cpufreq
driver) for an ACK.

Thanks!