Re: [PATCH v4 2/2] net: phy: dp83826: support TX data voltage tuning

From: POPESCU Catalin
Date: Mon Feb 12 2024 - 10:04:43 EST

On 12.02.24 15:37, Andrew Lunn wrote:
> [Some people who received this message don't often get email from andrew@xxxxxxx. Learn why this is important at ]
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
> On Mon, Feb 12, 2024 at 02:15:47PM +0000, POPESCU Catalin wrote:
>> I just figured out that I forgot to disable WOL in the callback config_init.
>> It looks the PHY driver should explicitly disable WOL feature at init,
>> and leave it to ethtool to be enabled.
>> I will provide a v5 ASAP to fix that.
> WoL is a bit murky. On x86, it can be the BIOS which configures WoL,
> behind the back of Linux. That is not something i would actually
> recommend, so disabling it at boot does make sense. But consider
> suspend and resume. If the PHY is used for WoL, the WoL settings
> should be kept through suspend/resume. So you need to be careful where
> you disable it, so its only disables on boot, not resume.
> Andrew

I see. Then, I should not disable WOL in config_init, since this
callback is also called on the resume path :
However, this contrasts with the rest of the driver and my patch is not
anymore about just adding support for tuning of TX voltage levels ...