Re: [PATCH v2] afs: Increase buffer size in afs_update_volume_status()

From: Jeffrey E Altman
Date: Mon Feb 12 2024 - 09:57:22 EST


On 2/12/2024 3:33 AM, Daniil Dulov wrote:
The max length of volume->vid value is 20 characters.
So increase idbuf[] size up to 20 to avoid overflow.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
Signed-off-by: Daniil Dulov <d.dulov@xxxxxxxxxx>
---
fs/afs/volume.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/afs/volume.c b/fs/afs/volume.c
index 020ecd45e476..d4a379bfd54e 100644
--- a/fs/afs/volume.c
+++ b/fs/afs/volume.c
@@ -353,7 +353,7 @@ static int afs_update_volume_status(struct afs_volume *volume, struct key *key)
{
struct afs_server_list *new, *old, *discard;
struct afs_vldb_entry *vldb;
- char idbuf[16];
+ char idbuf[20];
int ret, idsz;
_enter("");

Reviewed-by: Jeffrey Altman <jaltman@xxxxxxxxxxxx>