Re: [RFC PATCH net-next v2 6/7] net: ravb: Enable SW IRQ Coalescing for GbEth

[Paul Barker]

On 10/02/2024 18:42, Sergey Shtylyov wrote:
> On 2/6/24 12:19 PM, Paul Barker wrote:
>> diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
>> index 55a7a08aabef..ca7a66759e35 100644
>> --- a/drivers/net/ethernet/renesas/ravb.h
>> +++ b/drivers/net/ethernet/renesas/ravb.h
>> @@ -1078,6 +1078,7 @@ struct ravb_hw_info {
>>  	unsigned nc_queues:1;		/* AVB-DMAC has RX and TX NC queues */
>>  	unsigned magic_pkt:1;		/* E-MAC supports magic packet detection */
>>  	unsigned half_duplex:1;		/* E-MAC supports half duplex mode */
>> +	unsigned needs_irq_coalesce:1;	/* Requires SW IRQ Coalescing to achieve best performance */
> 
>    Is this really a hardware feature?

It's more like a requirement to get the best out of this hardware and the Linux networking stack.

I considered checking the compatible string in the probe function but I decided that storing a configuration bit in the HW info struct was cleaner.

>    Also, s/Requires SW/Needs software/ and s/to achieve best performance//,
> please...

Will do.

> 
> [...]
> 
> MBR, Sergey

Thanks for the review,
Paul

Attachment: OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature