Re: [PATCH] brcmfmac: Remove unnecessary NULL-check.

From: Kalle Valo
Date: Mon Feb 12 2024 - 02:27:59 EST


Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes:

> On 2/11/2024 4:05 PM, Daniil Dulov wrote:
>> In this case req will never be NULL, so remove unnecessary check.
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Looks good to me, but when do we call things a "fix" and when is
> "improvement" more appropriate.
>
>> Fixes: 71bb244ba2fd ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets")
> Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>

Yeah, this is not a fix and the Fixes tag should be removed.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches