Re: [PATCH] brcmfmac: Remove unnecessary NULL-check.

From: Arend van Spriel
Date: Sun Feb 11 2024 - 14:26:56 EST

On 2/11/2024 8:25 PM, Arend van Spriel wrote:
On 2/11/2024 4:05 PM, Daniil Dulov wrote:
In this case req will never be NULL, so remove unnecessary check.

Found by Linux Verification Center ( with SVACE.

Looks good to me, but when do we call things a "fix" and when is "improvement" more appropriate.

Fixes: 71bb244ba2fd ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets")
Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Daniil Dulov <d.dulov@xxxxxxxxxx>
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
index 9fb68c2dc7e3..38e4e4f32a39 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
@@ -455,8 +455,7 @@ brcmf_usbdev_qinit(struct list_head *q, int qsize)
      while (!list_empty(q)) {
          req = list_entry(q->next, struct brcmf_usbreq, list);
-        if (req)
-            usb_free_urb(req->urb);
+        usb_free_urb(req->urb);

Ay you are already touching this code you could consider using list_for_each_entry_safe().

That "Ay you are ..." should be "As you are ...".


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature