Re: [PATCH v3 2/5] dt-bindings: fpga: xlnx,fpga-slave-serial: rename gpios

[Krzysztof Kozlowski]

On 07/02/2024 19:01, Charles Perry wrote:
> By convention, gpio consumer names should not contain underscores
> (prog_b here) and shouldn't contain active low suffixes (-b here).
> 
> Signed-off-by: Charles Perry <charles.perry@xxxxxxxxxxxxxxxxxxxx>
> ---
>  .../bindings/fpga/xlnx,fpga-slave-serial.yaml        | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
> index 614d86ad825f3..650a4d8792b64 100644
> --- a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
> +++ b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
> @@ -36,7 +36,7 @@ properties:
>    reg:
>      maxItems: 1
>  
> -  prog_b-gpios:
> +  prog-gpios:

Please deprecate old property and add allOf excluding the usage of both.
Driver still parses old property, so we should have it documented.

https://lore.kernel.org/all/20230118163208.GA117919-robh@xxxxxxxxxx/

Best regards,
Krzysztof