Re: [PATCH] mm/memblock: Add MEMBLOCK_RSRV_NOINIT into flagname[] array

From: Mike Rapoport
Date: Sun Feb 11 2024 - 03:31:32 EST


On Fri, Feb 09, 2024 at 08:39:12AM +0530, Anshuman Khandual wrote:
> The commit 77e6c43e137c ("memblock: introduce MEMBLOCK_RSRV_NOINIT flag")
> skipped adding this newly introduced memblock flag into flagname[] array,
> thus preventing a correct memblock flags output for applicable memblock
> regions.
>
> Cc: Mike Rapoport <rppt@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>

Fixes: 77e6c43e137c ("memblock: introduce MEMBLOCK_RSRV_NOINIT flag")
Reviewed-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx>

> ---
> This applies on v6.8-rc3
>
> mm/memblock.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 4dcb2ee35eca..d9f4b82cbffe 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -2249,6 +2249,7 @@ static const char * const flagname[] = {
> [ilog2(MEMBLOCK_MIRROR)] = "MIRROR",
> [ilog2(MEMBLOCK_NOMAP)] = "NOMAP",
> [ilog2(MEMBLOCK_DRIVER_MANAGED)] = "DRV_MNG",
> + [ilog2(MEMBLOCK_RSRV_NOINIT)] = "RSV_NIT",
> };
>
> static int memblock_debug_show(struct seq_file *m, void *private)
> --
> 2.25.1
>

--
Sincerely yours,
Mike.