Re: [PATCH v2 2/5] pwm: dwc: Add 16 channel support for Intel Elkhart Lake

From: Uwe Kleine-König
Date: Sat Feb 10 2024 - 12:20:14 EST


Hello,

On Fri, Feb 09, 2024 at 09:41:50PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 09, 2024 at 09:18:41PM +0200, Raag Jadav wrote:
> > On Thu, Feb 08, 2024 at 07:20:59PM +0200, Andy Shevchenko wrote:
> > > On Thu, Feb 08, 2024 at 12:35:26PM +0530, Raag Jadav wrote:
> > > > Intel Elkhart Lake PSE includes two instances of PWM as a single PCI
> > > > function with 8 channels each. Add support for the remaining channels.
> > >
> > > Side Q: Have you used --histogram diff algo when prepared the series?
> > > If no, it's better to start using it.
> >
> > I used it for a few weeks, but I think I've grown a bit too comfortable
> > with patience.
> >
> > I'll use histogram for pinctrl stuff if you insist :)
>
> It's recommended by Torvalds:
> https://lore.kernel.org/linux-gpio/CAHk-=wiVNOFP1dzKdCqXvoery5p8QoBB5THiJUMbZ1TxJb7FhQ@xxxxxxxxxxxxxx/

BTW, the magic to use it by default is:

git config --global diff.algorithm histogram

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature