Re: [PATCH 1/2] iio: adc: ad4130: zero-initialize clock init data

[Jonathan Cameron]

On Thu, 08 Feb 2024 09:15:08 +0100
Nuno Sá <noname.nuno@xxxxxxxxx> wrote:

> On Wed, 2024-02-07 at 15:20 +0200, Cosmin Tanislav wrote:
> > The clk_init_data struct does not have all its members
> > initialized, causing issues when trying to expose the internal
> > clock on the CLK pin.
> > 
> > Fix this by zero-initializing the clk_init_data struct.
> > 
> > Fixes: 62094060cf3a ("iio: adc: ad4130: add AD4130 driver")
> > Signed-off-by: Cosmin Tanislav <demonsingur@xxxxxxxxx>
> > ---  
> 
> Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
Both applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> 
> >  drivers/iio/adc/ad4130.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad4130.c b/drivers/iio/adc/ad4130.c
> > index 53e19a863198..c7df499f9775 100644
> > --- a/drivers/iio/adc/ad4130.c
> > +++ b/drivers/iio/adc/ad4130.c
> > @@ -1794,7 +1794,7 @@ static int ad4130_setup_int_clk(struct ad4130_state *st)
> >  {
> >  	struct device *dev = &st->spi->dev;
> >  	struct device_node *of_node = dev_of_node(dev);
> > -	struct clk_init_data init;
> > +	struct clk_init_data init = {};
> >  	const char *clk_name;
> >  	int ret;
> >    
>