Re: [PATCH 2/3] pmdomain: qcom: rpmpd: Add MSM8974+PM8841 power domains

[Luca Weiss]

On Samstag, 10. Februar 2024 15:19:54 CET Konrad Dybcio wrote:
> On 2/10/24 15:12, Luca Weiss wrote:
> > Add the power domains CX & GFX found on devices with MSM8974 and PM8841.
> > 
> > Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> > ---
> 
> [...]
> 
> > +static struct rpmpd gfx_s4b_corner_ao;
> > +static struct rpmpd gfx_s4b_corner = {
> > +	.pd = { .name = "gfx", },
> > +	.peer = &gfx_s4b_corner_ao,
> > +	.res_type = RPMPD_SMPB,
> > +	.res_id = 4,
> > +	.key = KEY_CORNER,
> > +};
> > +
> > +static struct rpmpd gfx_s4b_corner_ao = {
> > +	.pd = { .name = "gfx_ao", },
> > +	.peer = &gfx_s4b_corner,
> > +	.active_only = true,
> > +	.res_type = RPMPD_SMPB,
> > +	.res_id = 4,
> > +	.key = KEY_CORNER,
> > +};
> 
> I don't see a s4b_ao downstream.. Though it's very unfortunate we
> didn't choose to add power-domain-cells or sth and set the bucket
> through that..

Right, overlooked that. Will drop gfx_ao for both this and the other patch.

Regards
Luca

> 
> Konrad