Re: [PATCH v3 3/5] iio: adc: ad7192: Use standard attribute

From: Jonathan Cameron
Date: Sat Feb 10 2024 - 10:52:50 EST


On Thu, 8 Feb 2024 19:24:57 +0200
Alisa-Dariana Roman <alisadariana@xxxxxxxxx> wrote:

> Replace custom attribute filter_low_pass_3db_frequency_available with
> standard attribute.
>
> Store the available values in ad7192_state struct.
>
> The function that used to compute those values replaced by
> ad7192_update_filter_freq_avail().
>
> Function ad7192_show_filter_avail() is no longer needed.
>
> Note that the initial available values are hardcoded.
>
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx>
Looks good. Thanks for tidying this up.

I've nothing to add to other reviews that have already come in for v3.

Thanks,

Jonathan