Re: [PATCH net-next v4] net/mlx5e: link NAPI instances to queues and IRQs

From: Tariq Toukan
Date: Sat Feb 10 2024 - 02:02:00 EST

On 09/02/2024 22:23, Joe Damato wrote:
Make mlx5 compatible with the newly added netlink queue GET APIs.

Signed-off-by: Joe Damato <jdamato@xxxxxxxxxx>
v3 -> v4:
- Use sq->netdev and sq->cq.napi to get the netdev and NAPI structures in
mlx5e_activate_txqsq and mlx5e_deactivate_txqsq as requested by Tariq
Toukan [1]
- Only set or unset NETDEV_QUEUE_TYPE_RX when the MLX5E_PTP_STATE_RX bit
is on in mlx5e_ptp_activate_channel and mlx5e_ptp_deactivate_channel as
requested by Rahul Rameshbabu [2]

v2 -> v3:
- Fix commit message subject
- call netif_queue_set_napi in mlx5e_ptp_activate_channel and
mlx5e_ptp_deactivate_channel to enable/disable NETDEV_QUEUE_TYPE_RX for
the PTP channel.
- Modify mlx5e_activate_txqsq and mlx5e_deactivate_txqsq to set
NETDEV_QUEUE_TYPE_TX which should take care of all TX queues including
QoS/HTB and PTP.
- Rearrange mlx5e_activate_channel and mlx5e_deactivate_channel for
better ordering when setting and unsetting NETDEV_QUEUE_TYPE_RX NAPI

v1 -> v2:
- Move netlink NULL code to mlx5e_deactivate_channel
- Move netif_napi_set_irq to mlx5e_open_channel and avoid storing the
irq, after netif_napi_add which itself sets the IRQ to -1


drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c | 5 ++++-
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 7 +++++++
2 files changed, 11 insertions(+), 1 deletion(-)

Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>
Thanks for your patch.