Re: [PATCH] regmap: kunit: Ensure that changed bytes are actually different

From: Mark Brown
Date: Fri Feb 09 2024 - 16:46:24 EST


On Fri, Feb 09, 2024 at 01:25:36PM -0800, Guenter Roeck wrote:

> + get_changed_bytes(&hw_buf[4], &val[0], sizeof(val));
> + // Let's cheat.
> + // Remember, the above code doesn't look into hw_buf[2..3],
> + // so anything might be in there, including the values from
> + // the val[] array.
> + hw_buf[2] = val[0];
> + hw_buf[3] = val[1];

Ugh, yeah - I'm paying attention to too many things at once today I
fear.

Attachment: signature.asc
Description: PGP signature